Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1482243006: VM: Small clean up and const-ness fix for Thread/OSThread constants. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Small clean up and const-ness fix for Thread/OSThread constants. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/59fd6c8397ccb712c0737e39658245c6a6783ca3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -35 lines) Patch
M runtime/bin/thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/thread_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_macos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/os_thread.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/os_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_android.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/os_thread_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/os_thread_linux.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/os_thread_macos.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/vm/os_thread_win.h View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/os_thread_win.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
5 years ago (2015-12-01 16:44:23 UTC) #2
srdjan
LGTM (siva is on vacation)
5 years ago (2015-12-01 18:34:39 UTC) #4
Florian Schneider
5 years ago (2015-12-02 11:30:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
59fd6c8397ccb712c0737e39658245c6a6783ca3.

Powered by Google App Engine
This is Rietveld 408576698