Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: runtime/vm/os_thread_android.h

Issue 1482243006: VM: Small clean up and const-ness fix for Thread/OSThread constants. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/os_thread.cc ('k') | runtime/vm/os_thread_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OS_THREAD_ANDROID_H_ 5 #ifndef VM_OS_THREAD_ANDROID_H_
6 #define VM_OS_THREAD_ANDROID_H_ 6 #define VM_OS_THREAD_ANDROID_H_
7 7
8 #if !defined(VM_OS_THREAD_H_) 8 #if !defined(VM_OS_THREAD_H_)
9 #error Do not include os_thread_android.h directly; use os_thread.h instead. 9 #error Do not include os_thread_android.h directly; use os_thread.h instead.
10 #endif 10 #endif
11 11
12 #include <pthread.h> 12 #include <pthread.h>
13 13
14 #include "platform/assert.h" 14 #include "platform/assert.h"
15 #include "platform/globals.h" 15 #include "platform/globals.h"
16 16
17 namespace dart { 17 namespace dart {
18 18
19 typedef pthread_key_t ThreadLocalKey; 19 typedef pthread_key_t ThreadLocalKey;
20 typedef pid_t ThreadId; 20 typedef pid_t ThreadId;
21 typedef pthread_t ThreadJoinId; 21 typedef pthread_t ThreadJoinId;
22 22
23
24 static const ThreadLocalKey kUnsetThreadLocalKey =
25 static_cast<pthread_key_t>(-1);
26
27
23 class ThreadInlineImpl { 28 class ThreadInlineImpl {
24 private: 29 private:
25 ThreadInlineImpl() {} 30 ThreadInlineImpl() {}
26 ~ThreadInlineImpl() {} 31 ~ThreadInlineImpl() {}
27 32
28 static uword GetThreadLocal(ThreadLocalKey key) { 33 static uword GetThreadLocal(ThreadLocalKey key) {
29 static ThreadLocalKey kUnsetThreadLocalKey = static_cast<pthread_key_t>(-1);
30 ASSERT(key != kUnsetThreadLocalKey); 34 ASSERT(key != kUnsetThreadLocalKey);
31 return reinterpret_cast<uword>(pthread_getspecific(key)); 35 return reinterpret_cast<uword>(pthread_getspecific(key));
32 } 36 }
33 37
34 friend class OSThread; 38 friend class OSThread;
35 39
36 DISALLOW_ALLOCATION(); 40 DISALLOW_ALLOCATION();
37 DISALLOW_COPY_AND_ASSIGN(ThreadInlineImpl); 41 DISALLOW_COPY_AND_ASSIGN(ThreadInlineImpl);
38 }; 42 };
39 43
(...skipping 27 matching lines...) Expand all
67 71
68 friend class Monitor; 72 friend class Monitor;
69 73
70 DISALLOW_ALLOCATION(); 74 DISALLOW_ALLOCATION();
71 DISALLOW_COPY_AND_ASSIGN(MonitorData); 75 DISALLOW_COPY_AND_ASSIGN(MonitorData);
72 }; 76 };
73 77
74 } // namespace dart 78 } // namespace dart
75 79
76 #endif // VM_OS_THREAD_ANDROID_H_ 80 #endif // VM_OS_THREAD_ANDROID_H_
OLDNEW
« no previous file with comments | « runtime/vm/os_thread.cc ('k') | runtime/vm/os_thread_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698