Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1482153002: rietveld.py: Change three_state_keys to emit "True" or "False" query params rather than 1/2. (Closed)

Created:
5 years ago by cbentzel
Modified:
5 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rietveld.py: Change three_state_keys to emit "True" or "False" query params rather than 1/2. Manually generating param strings shows that the 1/2 values do not work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297732

Patch Set 1 #

Patch Set 2 : Simplified query param generation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M rietveld.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/rietveld_test.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
cbentzel
5 years ago (2015-11-29 20:23:59 UTC) #2
M-A Ruel
rs lgtm if it works
5 years ago (2015-11-29 20:27:01 UTC) #3
cbentzel
On 2015/11/29 20:27:01, M-A Ruel wrote: > rs lgtm if it works It works. Simplified ...
5 years ago (2015-11-29 20:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482153002/20001
5 years ago (2015-11-29 20:42:32 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-29 20:44:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297732

Powered by Google App Engine
This is Rietveld 408576698