Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: rietveld.py

Issue 1482153002: rietveld.py: Change three_state_keys to emit "True" or "False" query params rather than 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Simplified query param generation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/rietveld_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index ec5d7814468dbf60afb31e3ec036173163ac9f81..6d78d00383c2f6410d6980ea5ae6bfa6b365e732 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -310,7 +310,7 @@ class Rietveld(object):
for key in sorted(three_state_keys):
value = three_state_keys[key]
if value is not None:
- url += '&%s=%d' % (key, int(value) + 1)
+ url += '&%s=%s' % (key, value)
if keys_only:
url += '&keys_only=True'
« no previous file with comments | « no previous file | tests/rietveld_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698