Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1482113002: Revert of [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, neis, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] (patchset #3 id:40001 of https://codereview.chromium.org/1474083003/ ) Reason for revert: [Sheriff] Speculative revert for gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/5164 Original issue's description: > [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] > > Both are integrated into JSReceiver::GetKeys(). > > For now, the implementation ignores Symbol/DONT_ENUM filtering. > > BUG=v8:1543 > LOG=n > > Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97 > Cr-Commit-Position: refs/heads/master@{#32384} TBR=verwaest@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Committed: https://crrev.com/97def40dc0b252b016e770eef0902d72643bcbaa Cr-Commit-Position: refs/heads/master@{#32385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -465 lines) Patch
M src/js/proxy.js View 1 chunk +25 lines, -24 lines 0 comments Download
M src/key-accumulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/key-accumulator.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/messages.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects.cc View 6 chunks +9 lines, -268 lines 0 comments Download
D test/mjsunit/harmony/proxies-enumerate.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/mjsunit/harmony/proxies-ownkeys.js View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]
5 years ago (2015-11-28 14:15:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482113002/1
5 years ago (2015-11-28 14:16:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-28 14:16:13 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-28 14:16:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97def40dc0b252b016e770eef0902d72643bcbaa
Cr-Commit-Position: refs/heads/master@{#32385}

Powered by Google App Engine
This is Rietveld 408576698