Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 1481983002: Drop [LegacyInterfaceTypeChecking] where trivial in core/ (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, tzik, blink-reviews-css, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, nhiroki, darktears, blink-reviews, kinuko+fileapi, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] where trivial in core/ These are cases where passing null to the implementation would already throw an exception, and so letting the bindings code do it is cleaner. In a few cases this means that the implementation no longer throws any exceptions. For each method affected, it was verified using cs.chromium.org that there are no internal calls where nullptr could be passed, the only calls are from bindings. BUG=561338 Committed: https://crrev.com/47ce5feb1d13ce889da15f76f063a7978a0b5c37 Cr-Commit-Position: refs/heads/master@{#362117}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -99 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-set-operations.html View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-set-operations-expected.txt View 1 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/MutationObserver/observe-exceptions-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/TreeWalker/resources/TreeWalker-currentNode.js View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/setDragImage-type-checking.html View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/workers/worker-read-blob-sync-expected.txt View 1 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/workers/worker-read-file-sync-expected.txt View 1 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 3 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeWalker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeWalker.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeWalker.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 4 chunks +4 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
philipj_slow
PTAL
5 years ago (2015-11-30 09:37:20 UTC) #4
haraken
LGTM
5 years ago (2015-11-30 09:42:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481983002/40001
5 years ago (2015-11-30 09:43:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 10:57:05 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 10:57:49 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47ce5feb1d13ce889da15f76f063a7978a0b5c37
Cr-Commit-Position: refs/heads/master@{#362117}

Powered by Google App Engine
This is Rietveld 408576698