Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

Issue 1481983002: Drop [LegacyInterfaceTypeChecking] where trivial in core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp
diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp b/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp
index b2b8004c030b0422539343b98879f1aa38003944..9f37e17142cef0cd8d28d3995121c2040434905a 100644
--- a/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp
+++ b/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp
@@ -47,10 +47,7 @@ FileReaderSync::FileReaderSync()
PassRefPtr<DOMArrayBuffer> FileReaderSync::readAsArrayBuffer(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)
{
- if (!blob) {
- exceptionState.throwDOMException(NotFoundError, FileError::notFoundErrorMessage);
- return nullptr;
- }
+ ASSERT(blob);
FileReaderLoader loader(FileReaderLoader::ReadAsArrayBuffer, nullptr);
startLoading(executionContext, loader, *blob, exceptionState);
@@ -60,10 +57,7 @@ PassRefPtr<DOMArrayBuffer> FileReaderSync::readAsArrayBuffer(ExecutionContext* e
String FileReaderSync::readAsBinaryString(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)
{
- if (!blob) {
- exceptionState.throwDOMException(NotFoundError, FileError::notFoundErrorMessage);
- return String();
- }
+ ASSERT(blob);
FileReaderLoader loader(FileReaderLoader::ReadAsBinaryString, 0);
startLoading(executionContext, loader, *blob, exceptionState);
@@ -72,10 +66,7 @@ String FileReaderSync::readAsBinaryString(ExecutionContext* executionContext, Bl
String FileReaderSync::readAsText(ExecutionContext* executionContext, Blob* blob, const String& encoding, ExceptionState& exceptionState)
{
- if (!blob) {
- exceptionState.throwDOMException(NotFoundError, FileError::notFoundErrorMessage);
- return String();
- }
+ ASSERT(blob);
FileReaderLoader loader(FileReaderLoader::ReadAsText, nullptr);
loader.setEncoding(encoding);
@@ -85,10 +76,7 @@ String FileReaderSync::readAsText(ExecutionContext* executionContext, Blob* blob
String FileReaderSync::readAsDataURL(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)
{
- if (!blob) {
- exceptionState.throwDOMException(NotFoundError, FileError::notFoundErrorMessage);
- return String();
- }
+ ASSERT(blob);
FileReaderLoader loader(FileReaderLoader::ReadAsDataURL, nullptr);
loader.setDataType(blob->type());
« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeWalker.idl ('k') | third_party/WebKit/Source/core/fileapi/FileReaderSync.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698