Move crash keys for command-line switches to components/crash so they can be set

chrome/common/crash_keys.h

Index: chrome/common/crash_keys.h
diff --git a/chrome/common/crash_keys.h b/chrome/common/crash_keys.h
index 03767fe96021e84828d936b4f29d0d07ca4f2cf2..0695af95d43cd5a0438999b693fff53197d3e0b1 100644
--- a/chrome/common/crash_keys.h
+++ b/chrome/common/crash_keys.h
@@ -22,8 +22,9 @@ namespace crash_keys {
 // reporting server. Returns the size of the union of all keys.
 size_t RegisterChromeCrashKeys();
 
-// Sets the kSwitch and kNumSwitches keys based on the given |command_line|.
-void SetSwitchesFromCommandLine(const base::CommandLine* command_line);
+// Sets the kNumSwitches key and a set of keys named using kSwitchFormat based

[grt (UTC plus 2), 2015/11/28 02:04:30]

comment nit to be addressed if you need to make other changes:
"the set of keys named" rather than "a set of keys named" since the set of names
is fixed (there can be only one).

[Joe Mason, 2015/11/30 17:23:55]

Done.

+// on the given |command_line|.
+void SetCrashKeysFromCommandLine(const base::CommandLine& command_line);
 
 // Sets the list of "active" extensions in this process. We overload "active" to
 // mean different things depending on the process type:
@@ -49,14 +50,6 @@ class ScopedPrinterInfo {
 // The URL of the active tab.
 extern const char kActiveURL[];
 
-// Process command line switches. |kSwitch| should be formatted with an integer,
-// in the range [1, kSwitchesMaxCount].
-const size_t kSwitchesMaxCount = 15;
-extern const char kSwitch[];
-// The total number of switches, used to report the total in case more than
-// |kSwitchesMaxCount| are present.
-extern const char kNumSwitches[];
-
 // Installed extensions. |kExtensionID| should be formatted with an integer,
 // in the range [0, kExtensionIDMaxCount).
 const size_t kExtensionIDMaxCount = 10;