Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6768)

Unified Diff: chrome/common/crash_keys.h

Issue 1481933002: Move crash keys for command-line switches to components/crash so they can be set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@installer_crash_keys
Patch Set: Get rid of default argument Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/crash_keys.h
diff --git a/chrome/common/crash_keys.h b/chrome/common/crash_keys.h
index 03767fe96021e84828d936b4f29d0d07ca4f2cf2..0695af95d43cd5a0438999b693fff53197d3e0b1 100644
--- a/chrome/common/crash_keys.h
+++ b/chrome/common/crash_keys.h
@@ -22,8 +22,9 @@ namespace crash_keys {
// reporting server. Returns the size of the union of all keys.
size_t RegisterChromeCrashKeys();
-// Sets the kSwitch and kNumSwitches keys based on the given |command_line|.
-void SetSwitchesFromCommandLine(const base::CommandLine* command_line);
+// Sets the kNumSwitches key and a set of keys named using kSwitchFormat based
grt (UTC plus 2) 2015/11/28 02:04:30 comment nit to be addressed if you need to make ot
Joe Mason 2015/11/30 17:23:55 Done.
+// on the given |command_line|.
+void SetCrashKeysFromCommandLine(const base::CommandLine& command_line);
// Sets the list of "active" extensions in this process. We overload "active" to
// mean different things depending on the process type:
@@ -49,14 +50,6 @@ class ScopedPrinterInfo {
// The URL of the active tab.
extern const char kActiveURL[];
-// Process command line switches. |kSwitch| should be formatted with an integer,
-// in the range [1, kSwitchesMaxCount].
-const size_t kSwitchesMaxCount = 15;
-extern const char kSwitch[];
-// The total number of switches, used to report the total in case more than
-// |kSwitchesMaxCount| are present.
-extern const char kNumSwitches[];
-
// Installed extensions. |kExtensionID| should be formatted with an integer,
// in the range [0, kExtensionIDMaxCount).
const size_t kExtensionIDMaxCount = 10;

Powered by Google App Engine
This is Rietveld 408576698