Move crash keys for command-line switches to components/crash so they can be set

chrome/common/crash_keys.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CRASH_KEYS_H_
 #define CHROME_COMMON_CRASH_KEYS_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/debug/crash_logging.h"
 #include "components/crash/core/common/crash_keys.h"
 
 namespace base {
 class CommandLine;
 }
 
 namespace crash_keys {
 
 // Registers all of the potential crash keys that can be sent to the crash
 // reporting server. Returns the size of the union of all keys.
 size_t RegisterChromeCrashKeys();
 
-// Sets the kSwitch and kNumSwitches keys based on the given |command_line|.
-void SetSwitchesFromCommandLine(const base::CommandLine* command_line);
+// Sets the kNumSwitches key and a set of keys named using kSwitchFormat based

[grt (UTC plus 2), 2015/11/28 02:04:30]

comment nit to be addressed if you need to make other changes:
"the set of keys named" rather than "a set of keys named" since the set of names
is fixed (there can be only one).

[Joe Mason, 2015/11/30 17:23:55]

Done.

+// on the given |command_line|.
+void SetCrashKeysFromCommandLine(const base::CommandLine& command_line);
 
 // Sets the list of "active" extensions in this process. We overload "active" to
 // mean different things depending on the process type:
 // - browser: all enabled extensions
 // - renderer: the unique set of extension ids from all content scripts
 // - extension: the id of each extension running in this process (there can be
 //   multiple because of process collapsing).
 void SetActiveExtensions(const std::set<std::string>& extensions);
 
 // Sets the printer info. Data should be separated by ';' up to
 // kPrinterInfoCount substrings. Each substring will be truncated if necessary.
 class ScopedPrinterInfo {
  public:
   explicit ScopedPrinterInfo(const base::StringPiece& data);
   ~ScopedPrinterInfo();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ScopedPrinterInfo);
 };
 
 // Crash Key Name Constants ////////////////////////////////////////////////////
 
 // The URL of the active tab.
 extern const char kActiveURL[];
 
-// Process command line switches. |kSwitch| should be formatted with an integer,
-// in the range [1, kSwitchesMaxCount].
-const size_t kSwitchesMaxCount = 15;
-extern const char kSwitch[];
-// The total number of switches, used to report the total in case more than
-// |kSwitchesMaxCount| are present.
-extern const char kNumSwitches[];
-
 // Installed extensions. |kExtensionID| should be formatted with an integer,
 // in the range [0, kExtensionIDMaxCount).
 const size_t kExtensionIDMaxCount = 10;
 extern const char kExtensionID[];
 // The total number of installed extensions, recorded in case it exceeds
 // kExtensionIDMaxCount. Also used in chrome/app, but defined here to avoid
 // a common->app dependency.
 extern const char kNumExtensionsCount[];
 
 // Type of shutdown. The value is one of "close" for WINDOW_CLOSE,
@@ skipping 56 matching lines @@
 // Numbers of active views.
 extern const char kViewCount[];
 
 // TEMPORARY: The encoder/frame details at the time a zero-length encoded frame
 // was encountered.  http://crbug.com/519022
 extern const char kZeroEncodeDetails[];
 
 }  // namespace crash_keys
 
 #endif  // CHROME_COMMON_CRASH_KEYS_H_