Issue 148193002: Removed most of path utility functions in Files app.

Issue 148193002: Removed most of path utility functions in Files app. (Closed)

Created:
6 years, 11 months ago by mtomasz

Modified:
6 years, 10 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed most of path utility functions in Files app. This patch removes some random dependencies to PathUtils and migrates to LocationInfo in that places. Also, most of the path utilities were removed. TEST=Tested manually. Partly browser_tests. BUG=320967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247951

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -349 lines)			Patch
M	chrome/browser/resources/file_manager/background/js/volume_manager.js	View	1	2 chunks	+3 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/file_manager/common/js/path_util.js	View		1 chunk	+0 lines, -211 lines	0 comments	Download
M	chrome/browser/resources/file_manager/common/js/util.js	View	1	1 chunk	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/directory_model.js	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_manager.js	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/file_tasks.js	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/volume_manager_wrapper.js	View	1	2 chunks	+7 lines, -26 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/148193002/40001

6 years, 10 months ago (2014-01-30 06:48:32 UTC) #3

commit-bot: I haz the power

Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144602

6 years, 10 months ago (2014-01-30 08:33:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/148193002/40001

6 years, 10 months ago (2014-01-30 10:08:32 UTC) #5

Message was sent while issue was closed.

Change committed as 247951

Expand Messages | Collapse Messages