chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js - Issue 148193002: Removed most of path utility functions in Files app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js

Issue 148193002: Removed most of path utility functions in Files app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/file_manager/foreground/js/file_tasks.js ('k') | chrome/browser/resources/file_manager/foreground/js/volume_manager_wrapper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js b/chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js

index e8a09c09c5cd0e8fc5e01732d2b53292da08b6f4..22eb22e174129b02174311ce56a3e0c19ae21313 100644

--- a/chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js

+++ b/chrome/browser/resources/file_manager/foreground/js/folder_shortcuts_data_model.js

@@ -31,7 +31,9 @@ function FolderShortcutsDataModel(volumeManager) {

var path = list[index];

group.add(function(path, callback) {

// TODO(mtomasz): Migrate to URL.

- volumeManager.resolveAbsolutePath(path, function(entry) {

+ // TODO(mtomasz): Do not resolve, if volumeInfo for Drive is missing.

+ var url = util.makeFilesystemUrl(path);

+ webkitResolveLocalFileSystemURL(url, function(entry) {

if (entry.fullPath in this.pendingPaths_)

delete this.pendingPaths_[entry.fullPath];

this.addInternal_(entry);