Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 148183014: Fix local printing URL parameter names (Closed)

Created:
6 years, 10 months ago by Noam Samuel
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix local printing URL parameter names Local printing URL parameter names do not match those in the privet spec. Fix this so they do match it. BUG=338868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M chrome/browser/local_discovery/privet_http_impl.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 7 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noam Samuel
6 years, 10 months ago (2014-01-28 22:30:46 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 10 months ago (2014-01-28 23:33:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/148183014/1
6 years, 10 months ago (2014-01-28 23:35:31 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:25:56 UTC) #4
Message was sent while issue was closed.
Change committed as 247595

Powered by Google App Engine
This is Rietveld 408576698