Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4603)

Unified Diff: chrome/browser/local_discovery/privet_http_unittest.cc

Issue 148183014: Fix local printing URL parameter names (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/local_discovery/privet_http_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/privet_http_unittest.cc
diff --git a/chrome/browser/local_discovery/privet_http_unittest.cc b/chrome/browser/local_discovery/privet_http_unittest.cc
index 1a6ccbfb7d96adaa0574d117f1a54a812ca38974..e895545f80a6b533f1518f047eb50aa5b3f38300 100644
--- a/chrome/browser/local_discovery/privet_http_unittest.cc
+++ b/chrome/browser/local_discovery/privet_http_unittest.cc
@@ -826,7 +826,8 @@ TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrint) {
// TODO(noamsml): Is encoding spaces as pluses standard?
EXPECT_TRUE(SuccessfulResponseToURLAndData(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name"),
"Sample print data",
kSampleLocalPrintResponse));
};
@@ -851,7 +852,8 @@ TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithAnyMimetype) {
// TODO(noamsml): Is encoding spaces as pluses standard?
EXPECT_TRUE(SuccessfulResponseToURLAndData(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name"),
"Sample print data",
kSampleLocalPrintResponse));
};
@@ -876,7 +878,8 @@ TEST_F(PrivetLocalPrintTest, SuccessfulPWGLocalPrint) {
// TODO(noamsml): Is encoding spaces as pluses standard?
EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name"),
+ "client_name=Chrome&user_name=sample%40gmail.com"
+ "&job_name=Sample+job+name"),
base::FilePath(FILE_PATH_LITERAL("path/to/test.pdf")),
kSampleLocalPrintResponse));
};
@@ -907,7 +910,8 @@ TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithCreatejob) {
// TODO(noamsml): Is encoding spaces as pluses standard?
EXPECT_TRUE(SuccessfulResponseToURLAndData(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name&job_id=1234"),
"Sample print data",
kSampleLocalPrintResponse));
};
@@ -936,7 +940,8 @@ TEST_F(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
// TODO(noamsml): Is encoding spaces as pluses standard?
EXPECT_TRUE(SuccessfulResponseToURLAndData(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name&job_id=1234"),
"sample/path/",
kSampleInvalidDocumentTypeResponse));
@@ -944,7 +949,8 @@ TEST_F(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name&job_id=1234"),
base::FilePath(FILE_PATH_LITERAL("sample/path/test.pdf")),
kSampleLocalPrintResponse));
};
@@ -972,7 +978,8 @@ TEST_F(PrivetLocalPrintTest, LocalPrintRetryOnInvalidJobID) {
EXPECT_TRUE(SuccessfulResponseToURLAndData(
GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
- "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
+ "client_name=Chrome&user_name=sample%40gmail.com&"
+ "job_name=Sample+job+name&job_id=1234"),
"Sample print data",
kSampleErrorResponsePrinterBusy));
« no previous file with comments | « chrome/browser/local_discovery/privet_http_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698