Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 148183012: Implement additional set operators: STLSetUnion, STLSetIntersection and STLIncludes. (Closed)

Created:
6 years, 10 months ago by rpaquay
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement additional set operators: STLSetUnion, STLSetIntersection and STLIncludes. BUG=336824 TBR=willchan@chromium.org, jyasskin@chromium.org (lgtm'ed in https://codereview.chromium.org/145663004/) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -3 lines) Patch
base/stl_util.h View 2 chunks +40 lines, -3 lines 0 comments Download
base/stl_util_unittest.cc View 3 chunks +160 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/148183012/1
6 years, 10 months ago (2014-01-28 23:04:02 UTC) #1
willchan no longer on Chromium
LGTM, but can you include the specific operators in the CL description? I'm kinda anal ...
6 years, 10 months ago (2014-01-28 23:42:12 UTC) #2
rpaquay
On 2014/01/28 23:42:12, willchan wrote: > LGTM, but can you include the specific operators in ...
6 years, 10 months ago (2014-01-28 23:44:49 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-01-29 02:12:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/148183012/1
6 years, 10 months ago (2014-01-29 17:13:08 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 17:13:29 UTC) #6
Message was sent while issue was closed.
Change committed as 247711

Powered by Google App Engine
This is Rietveld 408576698