Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338
Committed: https://crrev.com/3d49a3c17c46a39da8d6d8ca1d392a4164522eb7
Cr-Commit-Position: refs/heads/master@{#362282}

[philipj_slow, 2015-11-27 17:57:43]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[philipj_slow, 2015-11-27 17:58:12]

philipj@opera.com changed reviewers:
+ kbr@chromium.org, rtoy@chromium.org

[philipj_slow, 2015-11-27 17:58:13]

PTAL

[commit-bot: I haz the power, 2015-11-27 17:58:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481793002/20001

[commit-bot: I haz the power, 2015-11-27 20:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 20:50:44]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2015-11-30 19:00:17]

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:601:
this._testPassed('threw ' + errorType + ': ' + error.message);
My Javascript-fu is too weak to understand what this is doing.  Can you explain
it to me?

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:67:
[RaisesException, MeasureAs=AudioContextCreateMediaStreamSource,
RaisesException] MediaStreamAudioSourceNode createMediaStreamSource(MediaStream
mediaStream);
Not your fault, but since you're touching this anyway, can you remove the
redundant(?) RaisesException at the end?  And in line 82.

[philipj_slow, 2015-11-30 19:21:59]

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:601:
this._testPassed('threw ' + errorType + ': ' + error.message);
On 2015/11/30 19:00:17, Raymond Toy wrote:
> My Javascript-fu is too weak to understand what this is doing.  Can you
explain
> it to me?

This is to handle the "native" error types that have individual interfaces,
listed in http://heycam.github.io/webidl/#idl-exceptions

When the errorType is "TypeError", it will see that window.TypeError is defined
and test `error instanceof TypeError`. I used self instead of window just in
case this framework is also used in workers, or will be.

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:67:
[RaisesException, MeasureAs=AudioContextCreateMediaStreamSource,
RaisesException] MediaStreamAudioSourceNode createMediaStreamSource(MediaStream
mediaStream);
On 2015/11/30 19:00:17, Raymond Toy wrote:
> Not your fault, but since you're touching this anyway, can you remove the
> redundant(?) RaisesException at the end?  And in line 82.

Done.

[philipj_slow, 2015-11-30 19:22:44]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338
==========

[hongchan, 2015-11-30 19:40:40]

hongchan@chromium.org changed reviewers:
+ hongchan@chromium.org

[hongchan, 2015-11-30 19:40:40]

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:601:
this._testPassed('threw ' + errorType + ': ' + error.message);
On 2015/11/30 19:21:59, philipj wrote:
> On 2015/11/30 19:00:17, Raymond Toy wrote:
> > My Javascript-fu is too weak to understand what this is doing.  Can you
> explain
> > it to me?
> 
> This is to handle the "native" error types that have individual interfaces,
> listed in http://heycam.github.io/webidl/#idl-exceptions
> 
> When the errorType is "TypeError", it will see that window.TypeError is
defined
> and test `error instanceof TypeError`. I used self instead of window just in
> case this framework is also used in workers, or will be.

Okay, the worker part convinced me. However, isn't this a bit more readable?

self.hasOwnProperty(errorType)

(...sorry, I am not a reviewer but wanted to contribute here.)

[philipj_slow, 2015-11-30 20:48:30]

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/1481793002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:601:
this._testPassed('threw ' + errorType + ': ' + error.message);
On 2015/11/30 19:40:40, hoch wrote:
> On 2015/11/30 19:21:59, philipj wrote:
> > On 2015/11/30 19:00:17, Raymond Toy wrote:
> > > My Javascript-fu is too weak to understand what this is doing.  Can you
> > explain
> > > it to me?
> > 
> > This is to handle the "native" error types that have individual interfaces,
> > listed in http://heycam.github.io/webidl/#idl-exceptions
> > 
> > When the errorType is "TypeError", it will see that window.TypeError is
> defined
> > and test `error instanceof TypeError`. I used self instead of window just in
> > case this framework is also used in workers, or will be.
> 
> Okay, the worker part convinced me. However, isn't this a bit more readable?
> 
> self.hasOwnProperty(errorType)
> 
> (...sorry, I am not a reviewer but wanted to contribute here.)

This assumes that interface objects (TypeError, Document, etc) are own
properties on the global object as opposed to attributes on Window.prototype,
which I was not sure about until I checked it:

http://heycam.github.io/webidl/#es-interfaces

Turns out it's supposed to be on the global object, so I've changed it as you
suggested.

[Raymond Toy, 2015-11-30 20:57:15]

lgtm.

Thanks for fixing this.  I guess there are quite a few more uses that we should
fix.

[Ken Russell (switch to Gerrit), 2015-11-30 21:17:32]

lgtm too based on rtoy's and hoch's reviews.

[philipj_slow, 2015-11-30 22:05:44]

On 2015/11/30 20:57:15, Raymond Toy wrote:
> lgtm.
> 
> Thanks for fixing this.  I guess there are quite a few more uses that we
should
> fix.

Yeah, there is. I think all that are left would cause exceptions to be thrown in
new situations, which changes the risk. Probably still safe, of course, but best
to do separately. Happy to review if my input should be needed on any such
change.

[philipj_slow, 2015-11-30 22:05:49]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-11-30 22:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481793002/60001

[commit-bot: I haz the power, 2015-11-30 23:58:17]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338
==========

[commit-bot: I haz the power, 2015-11-30 23:58:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-30 23:59:00]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Also drop redundant [RaisesException] in a few places.

BUG=561338

Committed: https://crrev.com/3d49a3c17c46a39da8d6d8ca1d392a4164522eb7
Cr-Commit-Position: refs/heads/master@{#362282}
==========

[commit-bot: I haz the power, 2015-11-30 23:59:01]

Patchset 4 (id:??) landed as
https://crrev.com/3d49a3c17c46a39da8d6d8ca1d392a4164522eb7
Cr-Commit-Position: refs/heads/master@{#362282}