third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp - Issue 1481793002: Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

Issue 1481793002: Drop [LegacyInterfaceTypeChecking] where trivial in Web Audio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self.hasOwnProperty(errorType) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBuffer.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

index d7c888848d0e54971342da1dda9e783cc74c0342..33879451908853f37c82b30575efd0970d8be752 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

@@ -208,15 +208,6 @@ void AudioBuffer::copyFromChannel(DOMFloat32Array* destination, long channelNumb

void AudioBuffer::copyFromChannel(DOMFloat32Array* destination, long channelNumber, unsigned long startInChannel, ExceptionState& exceptionState)

{

- if (!destination) {

- exceptionState.throwDOMException(

- TypeMismatchError,

- ExceptionMessages::argumentNullOrIncorrectType(

- 1,

- "Float32Array"));

- return;

- }

if (channelNumber < 0 || channelNumber >= static_cast<long>(m_channels.size())) {

exceptionState.throwDOMException(

IndexSizeError,

@@ -265,15 +256,6 @@ void AudioBuffer::copyToChannel(DOMFloat32Array* source, long channelNumber, Exc

void AudioBuffer::copyToChannel(DOMFloat32Array* source, long channelNumber, unsigned long startInChannel, ExceptionState& exceptionState)

{

- if (!source) {