Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 148173016: Checkpoint work to import new tests from the w3c repos. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 9 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Add update-w3c-deps script to Tools/Scripts This is a meta-import script that is responsible for doing all the git shenanigans to import new versions of the W3C Test repos. It uses import-w3c-tests to do the heavy lifting, but also does all of the git manipulation necessary to ensure clean version history. This patch also adds a 'W3CImportExpectations' files that lists which directories should be ignored during an import (i.e., it acts as a blacklist, so that we will otherwise pick up new changes automatically). Note that this script does *not* automatically push anything to a source repo. The user still needs to verify that the import works, update any TestExpectations suppressions, and push the repo changes back to the Blink mirrors of the W3C repos. BUG=242329 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169082

Patch Set 1 #

Patch Set 2 : more cleanup #

Total comments: 5

Patch Set 3 : merge forward, check for clean checkouts #

Patch Set 4 : remove dryrun; it does not really work right #

Patch Set 5 : update W3CImportExpectations, add --allow-local-blink-commits, other fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -8 lines) Patch
M LayoutTests/W3CImportExpectations View 1 2 3 4 4 chunks +32 lines, -1 line 0 comments Download
A Tools/Scripts/update-w3c-deps View 1 2 3 4 1 chunk +146 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_importer.py View 1 2 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dirk Pranke
Please take a look. The process is still a bit awkward, but getting cleaner. Now, ...
6 years, 10 months ago (2014-02-07 02:32:59 UTC) #1
ojan
lgtm https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps File Tools/Scripts/update-w3c-deps (right): https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps#newcode34 Tools/Scripts/update-w3c-deps:34: blink_commitish = cmd.run(['git', 'show-ref', 'HEAD']).split()[0] Should this assert ...
6 years, 10 months ago (2014-02-08 00:36:28 UTC) #2
Dirk Pranke
https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps File Tools/Scripts/update-w3c-deps (right): https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps#newcode34 Tools/Scripts/update-w3c-deps:34: blink_commitish = cmd.run(['git', 'show-ref', 'HEAD']).split()[0] On 2014/02/08 00:36:28, ojan ...
6 years, 10 months ago (2014-02-08 01:04:30 UTC) #3
Dirk Pranke
https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps File Tools/Scripts/update-w3c-deps (right): https://codereview.chromium.org/148173016/diff/20001/Tools/Scripts/update-w3c-deps#newcode46 Tools/Scripts/update-w3c-deps:46: if status and not 'nothing to commit, working directory ...
6 years, 9 months ago (2014-03-10 21:19:27 UTC) #4
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 9 months ago (2014-03-12 23:25:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/148173016/120001
6 years, 9 months ago (2014-03-12 23:25:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 23:27:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
6 years, 9 months ago (2014-03-12 23:27:03 UTC) #8
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 9 months ago (2014-03-13 00:26:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/148173016/120001
6 years, 9 months ago (2014-03-13 00:26:46 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 02:49:55 UTC) #11
Message was sent while issue was closed.
Change committed as 169082

Powered by Google App Engine
This is Rietveld 408576698