Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1481633002: Never reuse a VideoToolbox decompression session. (Closed)

Created:
5 years ago by sandersd (OOO until July 31)
Modified:
5 years ago
Reviewers:
watk
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Never reuse a VideoToolbox decompression session. Due to bugs in VTDecompressionSessionCanAcceptFormatDescription(), remove the logic that reuses decompression sessions and always create a new one. Tighten up the change detection to only trigger on keyframes. BUG=555043 Original review URL: https://codereview.chromium.org/1437153010 (cherry picked from commit 07c07c368ccf43348058f771e95759b58921d6cc) R=watk@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5fae2532d04f36f1fb9d16000745177465de5554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 12 chunks +18 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
watk
lgtm
5 years ago (2015-11-25 19:40:44 UTC) #3
sandersd (OOO until July 31)
5 years ago (2015-11-25 19:43:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5fae2532d04f36f1fb9d16000745177465de5554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698