Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1437153010: Never reuse a VideoToolbox decompression session. (Closed)

Created:
5 years, 1 month ago by sandersd (OOO until July 31)
Modified:
5 years, 1 month ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Never reuse a VideoToolbox decompression session. Due to bugs in VTDecompressionSessionCanAcceptFormatDescription(), remove the logic that reuses decompression sessions and always create a new one. Tighten up the change detection to only trigger on keyframes. BUG=555043 Committed: https://crrev.com/07c07c368ccf43348058f771e95759b58921d6cc Cr-Commit-Position: refs/heads/master@{#360697}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Comment typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 2 12 chunks +18 lines, -31 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sandersd (OOO until July 31)
5 years, 1 month ago (2015-11-14 00:35:48 UTC) #2
Pawel Osciak
lgtm%nit https://chromiumcodereview.appspot.com/1437153010/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://chromiumcodereview.appspot.com/1437153010/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode396 content/common/gpu/media/vt_video_decode_accelerator.cc:396: // makes no difference. Re-virify this and update ...
5 years, 1 month ago (2015-11-19 09:05:39 UTC) #3
sandersd (OOO until July 31)
https://chromiumcodereview.appspot.com/1437153010/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://chromiumcodereview.appspot.com/1437153010/diff/20001/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode396 content/common/gpu/media/vt_video_decode_accelerator.cc:396: // makes no difference. Re-virify this and update the ...
5 years, 1 month ago (2015-11-19 18:36:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437153010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437153010/40001
5 years, 1 month ago (2015-11-19 18:36:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/143289)
5 years, 1 month ago (2015-11-19 20:49:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437153010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437153010/40001
5 years, 1 month ago (2015-11-20 00:06:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-20 00:39:55 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 00:50:03 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07c07c368ccf43348058f771e95759b58921d6cc
Cr-Commit-Position: refs/heads/master@{#360697}

Powered by Google App Engine
This is Rietveld 408576698