Don't use Compositor::Initialize for Aura Android

Don't use Compositor::Initialize for Aura Android

The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669
Committed: https://crrev.com/fda1e7f4c4bb69a52d1be0c18366f53b89f81ce0
Cr-Commit-Position: refs/heads/master@{#362708}

[bshe, 2015-11-25 19:44:36]

Description was changed from

==========
Don't use Compositor::Initialize for Aura Android


The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=507792
==========

to

==========
Don't use Compositor::Initialize for Aura Android


The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669
==========

[bshe, 2015-11-30 22:20:54]

bshe@chromium.org changed reviewers:
+ sky@chromium.org

[bshe, 2015-11-30 22:20:55]

Hi Scott. Do you mind to take a look at this simple CL? This initiazlize
function is not implemented for Aura Android and we wont use it I believe. So
ifdef it.

[sky, 2015-11-30 23:56:20]

https://codereview.chromium.org/1481623002/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main_android.cc (right):

https://codereview.chromium.org/1481623002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main_android.cc:104:
content::Compositor::Initialize();
That this code was compiling tells me you still have the Initialize function. If
you're going to ifdef calling it, shouldn't you also ifdef the function
implementation?
Personally I would be inclined to leave this code as is and have an empty
implementation for android.

[bshe, 2015-12-01 02:24:16]

https://codereview.chromium.org/1481623002/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main_android.cc (right):

https://codereview.chromium.org/1481623002/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main_android.cc:104:
content::Compositor::Initialize();
On 2015/11/30 23:56:20, sky wrote:
> That this code was compiling tells me you still have the Initialize function.
If
> you're going to ifdef calling it, shouldn't you also ifdef the function
> implementation?
> Personally I would be inclined to leave this code as is and have an empty
> implementation for android.

ifdefed the function declaration.

Sorry. I probably did a bad job explaining this CL. My understanding is that we
will get a compile error for Aura Android without this ifdef. The implementation
for this function is not included in Aura Android. We don't expect to use
Android's compositor. So we use ifdef here instead of implement it for Aura
Android.

[sky, 2015-12-01 15:10:59]

LGTM

[bshe, 2015-12-02 14:28:43]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-12-02 14:29:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481623002/20001

[commit-bot: I haz the power, 2015-12-02 15:10:22]

Description was changed from

==========
Don't use Compositor::Initialize for Aura Android


The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669
==========

to

==========
Don't use Compositor::Initialize for Aura Android


The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669
==========

[commit-bot: I haz the power, 2015-12-02 15:10:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 15:10:56]

Description was changed from

==========
Don't use Compositor::Initialize for Aura Android


The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669
==========

to

==========
Don't use Compositor::Initialize for Aura Android

The static function is implemented in compositor_impl_android.cc. But Aura
Android wont compile the file.

BUG=561669

Committed: https://crrev.com/fda1e7f4c4bb69a52d1be0c18366f53b89f81ce0
Cr-Commit-Position: refs/heads/master@{#362708}
==========

[commit-bot: I haz the power, 2015-12-02 15:10:56]

Patchset 2 (id:??) landed as
https://crrev.com/fda1e7f4c4bb69a52d1be0c18366f53b89f81ce0
Cr-Commit-Position: refs/heads/master@{#362708}

[bshe, 2016-01-05 19:15:29]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1558273002/ by bshe@chromium.org.

The reason for reverting is: We dont need to support Aura Android at current
stage. Revert related code..