Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1481613003: [Proxies] Support constructable proxy as new.target (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Proxies] Support constructable proxy as new.target BUG=v8:1543, v8:3330, v8:3931 LOG=n Committed: https://crrev.com/88ac8aa5236195137d4a7aa18bcc5650a3bdca5a Cr-Commit-Position: refs/heads/master@{#32346}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -12 lines) Patch
M src/objects.h View 4 chunks +8 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +42 lines, -12 lines 0 comments Download
A test/mjsunit/es6/classes-proxy.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
5 years ago (2015-11-26 13:01:07 UTC) #2
Igor Sheludko
lgtm
5 years ago (2015-11-26 14:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481613003/40001
5 years ago (2015-11-26 14:56:11 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 15:22:46 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/88ac8aa5236195137d4a7aa18bcc5650a3bdca5a Cr-Commit-Position: refs/heads/master@{#32346}
5 years ago (2015-11-26 15:23:25 UTC) #8
Michael Achenbach
5 years ago (2015-11-26 16:17:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1480673004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

Powered by Google App Engine
This is Rietveld 408576698