Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1481573002: Update jinja2 to master (between 2.8 and 2.8.1); fix urlencode bug. (Closed)

Created:
5 years ago by M-A Ruel
Modified:
5 years ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Vadim Sh.
Base URL:
git@github.com:luci/luci-py.git@1_tools
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Update jinja2 to master (between 2.8 and 2.8.1); fix urlencode bug. - Update jinja2 to get access to urlencode. The version (2.6) included in GAE is ancient. - Include markupsafe v0.23, a dependency of jinja2. The version (0.15) included in GAE ancient. - Stop using jinja2 2.6 in all the app.yaml. The new functionality will be used in a follow up. R=stip@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/67b86052e82e00d93d6c76f3dd221f289fd07721

Patch Set 1 : . #

Patch Set 2 : Add import hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11761 lines, -49 lines) Patch
M appengine/auth_service/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/auth_service/module-backend.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/auth_service/test_replica_app/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/components/components/template.py View 1 1 chunk +3 lines, -1 line 0 comments Download
A appengine/components/components/third_party/jinja2/AUTHORS View 1 chunk +33 lines, -0 lines 0 comments Download
A + appengine/components/components/third_party/jinja2/LICENSE View 1 chunk +31 lines, -26 lines 0 comments Download
A appengine/components/components/third_party/jinja2/README.swarming View 1 chunk +14 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/__init__.py View 1 1 chunk +70 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/_compat.py View 1 chunk +102 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/_stringdefs.py View 1 chunk +132 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/bccache.py View 1 chunk +362 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/compiler.py View 1 chunk +1686 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/constants.py View 1 chunk +32 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/debug.py View 1 chunk +350 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/defaults.py View 1 chunk +43 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/environment.py View 1 chunk +1213 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/exceptions.py View 1 chunk +146 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/ext.py View 1 chunk +636 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/filters.py View 1 chunk +996 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/lexer.py View 1 chunk +734 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/loaders.py View 1 chunk +481 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/meta.py View 1 chunk +103 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/nodes.py View 1 chunk +919 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/optimizer.py View 1 chunk +68 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/parser.py View 1 chunk +899 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/runtime.py View 1 chunk +667 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/sandbox.py View 1 chunk +367 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/tests.py View 1 chunk +173 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/utils.py View 1 chunk +531 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/jinja2/visitor.py View 1 chunk +87 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/AUTHORS View 1 chunk +13 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/LICENSE View 1 chunk +33 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/README.swarming View 1 chunk +13 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/__init__.py View 1 chunk +298 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/_compat.py View 1 chunk +26 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/_constants.py View 1 chunk +267 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/_native.py View 1 chunk +46 lines, -0 lines 0 comments Download
A appengine/components/components/third_party/markupsafe/tests.py View 1 chunk +179 lines, -0 lines 0 comments Download
M appengine/components/components/utils.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M appengine/components/tests/test_endpoints_app/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/config_service/app.yaml View 1 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/config_service/module-backend.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/gce-backend/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/isolate/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/isolate/module-backend.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/machine_provider/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/swarming/app.yaml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
M-A Ruel
5 years ago (2015-11-25 16:11:34 UTC) #2
ghost stip (do not use)
lgtm on the assumption that components/third_party is always uploaded
5 years ago (2015-11-25 20:01:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481573002/20001
5 years ago (2015-11-25 20:12:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/426)
5 years ago (2015-11-25 20:29:44 UTC) #8
M-A Ruel
On 2015/11/25 20:29:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-11-26 02:29:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481573002/40001
5 years ago (2015-12-02 02:31:51 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-02 02:34:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-py/commit/67b86052e82e00d93d6c76f3dd221f289fd07721

Powered by Google App Engine
This is Rietveld 408576698