Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/browser/ui/android/toolbar/toolbar_model_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/toolbar/toolbar_model_android.cc
diff --git a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc
index 9c7241cabb40915f8811334d58136a28618901ff..c05d4ad72fdcccece1ec03998c6c25eb6ebfe808 100644
--- a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc
+++ b/chrome/browser/ui/android/toolbar/toolbar_model_android.cc
@@ -27,25 +27,29 @@ ToolbarModelAndroid::ToolbarModelAndroid(JNIEnv* env, jobject jdelegate)
ToolbarModelAndroid::~ToolbarModelAndroid() {
}
-void ToolbarModelAndroid::Destroy(JNIEnv* env, jobject obj) {
+void ToolbarModelAndroid::Destroy(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
delete this;
}
-ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetText(JNIEnv* env,
- jobject obj) {
+ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetText(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
return base::android::ConvertUTF16ToJavaString(env,
toolbar_model_->GetText());
}
ScopedJavaLocalRef<jstring> ToolbarModelAndroid::GetCorpusChipText(
JNIEnv* env,
- jobject obj) {
+ const JavaParamRef<jobject>& obj) {
return base::android::ConvertUTF16ToJavaString(
env,
toolbar_model_->GetCorpusNameForMobile());
}
-jboolean ToolbarModelAndroid::WouldReplaceURL(JNIEnv* env, jobject obj) {
+jboolean ToolbarModelAndroid::WouldReplaceURL(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
return toolbar_model_->WouldReplaceURL();
}
« no previous file with comments | « chrome/browser/ui/android/toolbar/toolbar_model_android.h ('k') | chrome/browser/ui/android/website_settings_popup_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698