chrome/browser/ui/android/toolbar/toolbar_model_android.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/toolbar/toolbar_model_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc ('k') | chrome/browser/ui/android/toolbar/toolbar_model_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/toolbar/toolbar_model_android.h

diff --git a/chrome/browser/ui/android/toolbar/toolbar_model_android.h b/chrome/browser/ui/android/toolbar/toolbar_model_android.h

index f5f9c7a1b72aceec8152d8558926112f828099e0..6500cdca690ccf154274e5c64bf77b11335e2941 100644

--- a/chrome/browser/ui/android/toolbar/toolbar_model_android.h

+++ b/chrome/browser/ui/android/toolbar/toolbar_model_android.h

@@ -23,14 +23,15 @@ class ToolbarModelAndroid : public ToolbarModelDelegate {

explicit ToolbarModelAndroid(JNIEnv* env, jobject jdelegate);

~ToolbarModelAndroid() override;

- void Destroy(JNIEnv* env, jobject obj);

+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

base::android::ScopedJavaLocalRef<jstring> GetText(

JNIEnv* env,

- jobject obj);

+ const base::android::JavaParamRef<jobject>& obj);

base::android::ScopedJavaLocalRef<jstring> GetCorpusChipText(

JNIEnv* env,

- jobject obj);

- jboolean WouldReplaceURL(JNIEnv* env, jobject obj);

+ const base::android::JavaParamRef<jobject>& obj);

+ jboolean WouldReplaceURL(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

// ToolbarDelegate:

content::WebContents* GetActiveWebContents() const override;