Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3920)

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
index d8590e920fb5aa45bc08f22dbee3f877b67165b7..0d3949f4d6f582903657717ef71ee88a699b79aa 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
@@ -47,12 +47,13 @@ TabModelJniBridge::TabModelJniBridge(JNIEnv* env,
TabModelList::AddTabModel(this);
}
-void TabModelJniBridge::Destroy(JNIEnv* env, jobject obj) {
+void TabModelJniBridge::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
delete this;
}
-ScopedJavaLocalRef<jobject> TabModelJniBridge::GetProfileAndroid(JNIEnv* env,
- jobject obj) {
+ScopedJavaLocalRef<jobject> TabModelJniBridge::GetProfileAndroid(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
ProfileAndroid* profile_android = ProfileAndroid::FromProfile(GetProfile());
if (!profile_android)
return ScopedJavaLocalRef<jobject>();
@@ -60,8 +61,8 @@ ScopedJavaLocalRef<jobject> TabModelJniBridge::GetProfileAndroid(JNIEnv* env,
}
void TabModelJniBridge::TabAddedToModel(JNIEnv* env,
- jobject obj,
- jobject jtab) {
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& jtab) {
// Tab#initialize() should have been called by now otherwise we can't push
// the window id.
TabAndroid* tab = TabAndroid::GetNativeTab(env, jtab);
@@ -145,8 +146,9 @@ bool TabModelJniBridge::IsSessionRestoreInProgress() const {
env, java_object_.get(env).obj());
}
-void TabModelJniBridge::BroadcastSessionRestoreComplete(JNIEnv* env,
- jobject obj) {
+void TabModelJniBridge::BroadcastSessionRestoreComplete(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
TabModel::BroadcastSessionRestoreComplete();
}
« no previous file with comments | « chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h ('k') | chrome/browser/ui/android/toolbar/toolbar_model_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698