Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2533)

Unified Diff: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
index bd2914d35e0fe1ff71a85dced608ec5fd7dd9ae9..46f91c3bf8be6df24805afe6abbb9acf5712f97b 100644
--- a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
+++ b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
@@ -51,15 +51,18 @@ CreditCardScannerViewAndroid::CreditCardScannerViewAndroid(
CreditCardScannerViewAndroid::~CreditCardScannerViewAndroid() {}
-void CreditCardScannerViewAndroid::ScanCancelled(JNIEnv* env, jobject object) {
+void CreditCardScannerViewAndroid::ScanCancelled(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object) {
delegate_->ScanCancelled();
}
-void CreditCardScannerViewAndroid::ScanCompleted(JNIEnv* env,
- jobject object,
- jstring card_number,
- jint expiration_month,
- jint expiration_year) {
+void CreditCardScannerViewAndroid::ScanCompleted(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ const JavaParamRef<jstring>& card_number,
+ jint expiration_month,
+ jint expiration_year) {
delegate_->ScanCompleted(
base::android::ConvertJavaStringToUTF16(env, card_number),
static_cast<int>(expiration_month), static_cast<int>(expiration_year));

Powered by Google App Engine
This is Rietveld 408576698