Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5458)

Unified Diff: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h
diff --git a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h
index 0928fc78503c68c2dc14ad2198a3daa5274a3b8c..15dd9c15da5b4d8947da7bb9089a1e566f508dfc 100644
--- a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h
+++ b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h
@@ -23,15 +23,20 @@ class CardUnmaskPromptViewAndroid : public CardUnmaskPromptView {
explicit CardUnmaskPromptViewAndroid(CardUnmaskPromptController* controller,
content::WebContents* web_contents);
- bool CheckUserInputValidity(JNIEnv* env, jobject obj, jstring response);
+ bool CheckUserInputValidity(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& response);
void OnUserInput(JNIEnv* env,
- jobject obj,
- jstring cvc,
- jstring month,
- jstring year,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& cvc,
+ const base::android::JavaParamRef<jstring>& month,
+ const base::android::JavaParamRef<jstring>& year,
jboolean should_store_locally);
- void OnNewCardLinkClicked(JNIEnv* env, jobject obj);
- void PromptDismissed(JNIEnv* env, jobject obj);
+ void OnNewCardLinkClicked(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void PromptDismissed(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
// CardUnmaskPromptView implementation.
void Show() override;

Powered by Google App Engine
This is Rietveld 408576698