Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8301)

Unified Diff: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
index b676d22b7f36f10b645095620c48a8d0783dd1cc..a0dd9c7a2003958c7878dd525919c0d1ed427447 100644
--- a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
+++ b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
@@ -53,19 +53,21 @@ void CardUnmaskPromptViewAndroid::Show() {
Java_CardUnmaskBridge_show(env, java_object_.obj());
}
-bool CardUnmaskPromptViewAndroid::CheckUserInputValidity(JNIEnv* env,
- jobject obj,
- jstring response) {
+bool CardUnmaskPromptViewAndroid::CheckUserInputValidity(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& response) {
return controller_->InputCvcIsValid(
base::android::ConvertJavaStringToUTF16(env, response));
}
-void CardUnmaskPromptViewAndroid::OnUserInput(JNIEnv* env,
- jobject obj,
- jstring cvc,
- jstring month,
- jstring year,
- jboolean should_store_locally) {
+void CardUnmaskPromptViewAndroid::OnUserInput(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& cvc,
+ const JavaParamRef<jstring>& month,
+ const JavaParamRef<jstring>& year,
+ jboolean should_store_locally) {
controller_->OnUnmaskResponse(
base::android::ConvertJavaStringToUTF16(env, cvc),
base::android::ConvertJavaStringToUTF16(env, month),
@@ -73,8 +75,9 @@ void CardUnmaskPromptViewAndroid::OnUserInput(JNIEnv* env,
should_store_locally);
}
-void CardUnmaskPromptViewAndroid::OnNewCardLinkClicked(JNIEnv* env,
- jobject obj) {
+void CardUnmaskPromptViewAndroid::OnNewCardLinkClicked(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
controller_->NewCardLinkClicked();
Java_CardUnmaskBridge_update(env, java_object_.obj(),
base::android::ConvertUTF16ToJavaString(
@@ -84,7 +87,9 @@ void CardUnmaskPromptViewAndroid::OnNewCardLinkClicked(JNIEnv* env,
controller_->ShouldRequestExpirationDate());
}
-void CardUnmaskPromptViewAndroid::PromptDismissed(JNIEnv* env, jobject obj) {
+void CardUnmaskPromptViewAndroid::PromptDismissed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698