Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3823)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.h
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.h b/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
index 10f6acd81305e4ee1e95fedf8531ec2ed8af197e..db8aff58342fdddfe84e841835fc9b34620005c7 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
@@ -27,13 +27,19 @@ class AutofillPopupViewAndroid : public AutofillPopupView {
// Methods called from Java via JNI
// --------------------------------------------------------------------------
// Called when an autofill item was selected.
- void SuggestionSelected(JNIEnv* env, jobject obj, jint list_index);
+ void SuggestionSelected(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint list_index);
- void DeletionRequested(JNIEnv* env, jobject obj, jint list_index);
+ void DeletionRequested(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint list_index);
- void DeletionConfirmed(JNIEnv* env, jobject obj);
+ void DeletionConfirmed(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
- void PopupDismissed(JNIEnv* env, jobject obj);
+ void PopupDismissed(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
static bool RegisterAutofillPopupViewAndroid(JNIEnv* env);

Powered by Google App Engine
This is Rietveld 408576698