Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
index ed42f87fd6d8ef3af4ab874dd0a12c9b13902511..f4448da6f153534156ac184918e964d387abff69 100644
--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
@@ -110,17 +110,19 @@ void AutofillKeyboardAccessoryView::UpdateBoundsAndRedrawPopup() {
env, java_object_.obj(), data_array.obj(), controller_->IsRTL());
}
-void AutofillKeyboardAccessoryView::SuggestionSelected(JNIEnv* env,
- jobject obj,
- jint list_index) {
+void AutofillKeyboardAccessoryView::SuggestionSelected(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint list_index) {
// Race: Hide() may have already run.
if (controller_)
controller_->AcceptSuggestion(positions_[list_index]);
}
-void AutofillKeyboardAccessoryView::DeletionRequested(JNIEnv* env,
- jobject obj,
- jint list_index) {
+void AutofillKeyboardAccessoryView::DeletionRequested(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint list_index) {
if (!controller_)
return;
@@ -137,8 +139,9 @@ void AutofillKeyboardAccessoryView::DeletionRequested(JNIEnv* env,
base::android::ConvertUTF16ToJavaString(env, confirmation_body).obj());
}
-void AutofillKeyboardAccessoryView::DeletionConfirmed(JNIEnv* env,
- jobject obj) {
+void AutofillKeyboardAccessoryView::DeletionConfirmed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (!controller_)
return;
@@ -146,7 +149,9 @@ void AutofillKeyboardAccessoryView::DeletionConfirmed(JNIEnv* env,
controller_->RemoveSuggestion(deleting_index_);
}
-void AutofillKeyboardAccessoryView::ViewDismissed(JNIEnv* env, jobject obj) {
+void AutofillKeyboardAccessoryView::ViewDismissed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (controller_)
controller_->ViewDestroyed();

Powered by Google App Engine
This is Rietveld 408576698