chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc ('k') | chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

index 779b43b4a1dcfc804dbee3ab3b5fd0e47c7f107d..31ecd26bd0316ac9fbd4d1bf150c4dbd33962186 100644

--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

@@ -32,13 +32,19 @@ class AutofillKeyboardAccessoryView : public AutofillPopupView {

// Methods called from Java via JNI

// --------------------------------------------------------------------------

// Called when an autofill item was selected.

- void SuggestionSelected(JNIEnv* env, jobject obj, jint list_index);

+ void SuggestionSelected(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ jint list_index);

- void DeletionRequested(JNIEnv* env, jobject obj, jint list_index);

+ void DeletionRequested(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ jint list_index);

- void DeletionConfirmed(JNIEnv* env, jobject obj);

+ void DeletionConfirmed(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

- void ViewDismissed(JNIEnv* env, jobject obj);

+ void ViewDismissed(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

static bool RegisterAutofillKeyboardAccessoryView(JNIEnv* env);