Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6512)

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
index bbd96ba9ff0ba4888367c36ab1341e1fd38a4af9..6e4e84f7d4aafbf75f2ac6498b25c048cfe3bf59 100644
--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc
@@ -428,8 +428,9 @@ bool AutofillDialogControllerAndroid::
return RegisterNativesImpl(env);
}
-void AutofillDialogControllerAndroid::DialogCancel(JNIEnv* env,
- jobject obj) {
+void AutofillDialogControllerAndroid::DialogCancel(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
LogOnCancelMetrics();
callback_.Run(AutofillClient::AutocompleteResultErrorCancel,
base::string16(),
@@ -438,13 +439,13 @@ void AutofillDialogControllerAndroid::DialogCancel(JNIEnv* env,
void AutofillDialogControllerAndroid::DialogContinue(
JNIEnv* env,
- jobject obj,
- jobject wallet,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& wallet,
jboolean jlast_used_choice_is_autofill,
- jstring jlast_used_account_name,
- jstring jlast_used_billing,
- jstring jlast_used_shipping,
- jstring jlast_used_card) {
+ const JavaParamRef<jstring>& jlast_used_account_name,
+ const JavaParamRef<jstring>& jlast_used_billing,
+ const JavaParamRef<jstring>& jlast_used_shipping,
+ const JavaParamRef<jstring>& jlast_used_card) {
const base::string16 email =
AutofillDialogResult::GetWalletEmail(env, wallet);
const std::string google_transaction_id =

Powered by Google App Engine
This is Rietveld 408576698