Protocol handler dialogs should only be enabled by browser or page actions [Not committed]

chrome/browser/extensions/extension_function_dispatcher.cc

Index: chrome/browser/extensions/extension_function_dispatcher.cc
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc
index 3ddafe6985d9215d85f4f7fb66be259c218ac674..5b6b902b249ec144aae6c6b3caa9a8926e5f1b68 100644
--- a/chrome/browser/extensions/extension_function_dispatcher.cc
+++ b/chrome/browser/extensions/extension_function_dispatcher.cc
@@ -19,7 +19,6 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
-#include "chrome/browser/external_protocol/external_protocol_handler.h"
 #include "chrome/browser/renderer_host/chrome_render_message_filter.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/url_constants.h"
@@ -382,9 +381,6 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(
                                               base::TimeTicks::Now());
   if (violation_error.empty()) {
     scoped_ptr<base::ListValue> args(params.arguments.DeepCopy());
-
-    // See crbug.com/39178.
-    ExternalProtocolHandler::PermitLaunchUrl();

[not at google - send to devlin, 2014/02/01 02:02:54]

I wonder whether a simpler fix to this would be to just guard this on
params.user_gesture, but I don't fully understand the interactions going on
here.

     LogSuccess(extension->id(), params.name, args.Pass(), browser_context_);
     function->Run();
   } else {