chrome/browser/extensions/api/messaging/message_service.cc - Issue 148153008: Protocol handler dialogs should only be enabled by browser or page actions [Not committed]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/message_service.cc

Issue 148153008: Protocol handler dialogs should only be enabled by browser or page actions [Not committed] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.cc ('k') | chrome/browser/extensions/extension_function_dispatcher.cc » ('j') | chrome/browser/extensions/extension_function_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/message_service.cc

diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc

index 8afd54fd35012e9694ec2c7e16d6d95edf5a8a45..9935618621316ad4b5064bdd54708a8a3660424e 100644

--- a/chrome/browser/extensions/api/messaging/message_service.cc

+++ b/chrome/browser/extensions/api/messaging/message_service.cc

@@ -20,6 +20,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/extension_util.h"

+#include "chrome/browser/external_protocol/external_protocol_handler.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/tab_contents/tab_util.h"

#include "chrome/common/extensions/extension_messages.h"

@@ -652,6 +653,8 @@ void MessageService::DispatchMessage(int source_port_id,

MessagePort* port = IS_OPENER_PORT_ID(dest_port_id) ?

channel->opener.get() : channel->receiver.get();

+ if (message.user_gesture)

+ ExternalProtocolHandler::PermitLaunchUrl();

port->DispatchOnMessage(message, dest_port_id);

}