Issue 148153003: Fix double escaping of senderIds in registration request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148153003: Fix double escaping of senderIds in registration request. (Closed)

Created:
6 years, 11 months ago by pavely

Modified:
6 years, 10 months ago

Reviewers:
Nicolas Zea, fgorski

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix double escaping of senderIds in registration request. SenderId can be either integer obtained from developer dashboard or email. Android chrome invalidations uses email. Fix double escaping so that registration server accepts senderId. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247592

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	google_apis/gcm/engine/registration_request.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	google_apis/gcm/engine/registration_request_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

fgorski

zea@chromium.org: Please review changes in Adding Nicolas, who is the owner.

6 years, 11 months ago (2014-01-27 17:54:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/148153003/1

6 years, 10 months ago (2014-01-28 18:27:50 UTC) #5

Message was sent while issue was closed.

Change committed as 247592

Expand Messages | Collapse Messages