google_apis/gcm/engine/registration_request.cc - Issue 148153003: Fix double escaping of senderIds in registration request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/registration_request.cc

Issue 148153003: Fix double escaping of senderIds in registration request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/engine/registration_request.cc

diff --git a/google_apis/gcm/engine/registration_request.cc b/google_apis/gcm/engine/registration_request.cc

index 64f49a94aa217d188ee0adad3498a5a24cbd81fa..bbf643acfec750e3a5e8bd1210953104a80c5ade 100644

--- a/google_apis/gcm/engine/registration_request.cc

+++ b/google_apis/gcm/engine/registration_request.cc

@@ -111,7 +111,7 @@ void RegistrationRequest::Start() {

DCHECK(!iter->empty());

if (!senders.empty())

senders.append(",");

- senders.append(net::EscapeUrlEncodedData(*iter, true));

+ senders.append(*iter);

}

BuildFormEncoding(kSenderKey, senders, &body);

« no previous file with comments | « no previous file | google_apis/gcm/engine/registration_request_unittest.cc » ('j') | no next file with comments »