Fix size_t truncations in net for 64-bit VS 2015

Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
Committed: https://crrev.com/ef12824d24aba9469533cb6256eccded3297e94d
Cr-Commit-Position: refs/heads/master@{#362345}

[brucedawson, 2015-12-01 01:05:06]

PTAL.

Fixing the truncation warnings seems better than suppressing them in the .gn
files, and should make it easier to enable these warnings in the .gyp files if
we want.

Try bots are running now.

[brucedawson, 2015-12-01 01:05:19]

Description was changed from

==========
Fix size_t truncation warnings for 64-bit VS 2015 compat

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

to

==========
Fix size_t truncations in webkit for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

[Ryan Sleevi, 2015-12-01 01:23:47]

Description was changed from

==========
Fix size_t truncations in webkit for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

to

==========
Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

[Ryan Sleevi, 2015-12-01 01:25:58]

LGTM % nit

Also, updated description, which originally said "in webkit", to be "in net"

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
File net/socket/socks5_client_socket_unittest.cc (right):

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
net/socket/socks5_client_socket_unittest.cc:197:
request.push_back(base::checked_cast<char>(hostname.size()));
This is a test - shouldn't it just be static?

[brucedawson, 2015-12-01 01:33:46]

Thanks for the description catch/fix.

Thoughts on why static over checked?

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
File net/socket/socks5_client_socket_unittest.cc (right):

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
net/socket/socks5_client_socket_unittest.cc:197:
request.push_back(base::checked_cast<char>(hostname.size()));
On 2015/12/01 01:25:58, Ryan Sleevi wrote:
> This is a test - shouldn't it just be static?

My assumption was that tests are the awesomest place for checked_cast because we
don't need to worry about the code-size tradeoffs so we can even-more ruthlessly
expose bugs.

[Ryan Sleevi, 2015-12-01 01:44:17]

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
File net/socket/socks5_client_socket_unittest.cc (right):

https://codereview.chromium.org/1481403005/diff/1/net/socket/socks5_client_so...
net/socket/socks5_client_socket_unittest.cc:197:
request.push_back(base::checked_cast<char>(hostname.size()));
On 2015/12/01 01:33:45, brucedawson wrote:
> On 2015/12/01 01:25:58, Ryan Sleevi wrote:
> > This is a test - shouldn't it just be static?
> 
> My assumption was that tests are the awesomest place for checked_cast because
we
> don't need to worry about the code-size tradeoffs so we can even-more
ruthlessly
> expose bugs.

Because line 188 makes it 'obviously correct', and you seemed to omit it for the
other tests that were similarly obviously correct :)

[brucedawson, 2015-12-01 01:54:57]

> Because line 188 makes it 'obviously correct', and you seemed to omit it for
the
> other tests that were similarly obviously correct :)

That makes more sense.

I can make a case for it either way, so I'll happily defer to your owners'
preference. Fixed.

Committing momentarily.

[brucedawson, 2015-12-01 01:56:04]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-12-01 01:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1481403005/#ps20001
(title: "CR feedback")

[commit-bot: I haz the power, 2015-12-01 01:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481403005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481403005/20001

[commit-bot: I haz the power, 2015-12-01 04:26:43]

Description was changed from

==========
Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

to

==========
Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

[commit-bot: I haz the power, 2015-12-01 04:26:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-01 04:28:14]

Description was changed from

==========
Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500
==========

to

==========
Fix size_t truncations in net for 64-bit VS 2015

These changes are enough to get the net portions of Chromium building
with VS 2015 in 64-bit gn builds. The changes are all to fix warnings
about truncation from size_t to smaller types.

A mixture of static_cast and checked_cast was used depending on whether
the truncation could be proved correct and whether the code was in a
test.

R=rsleevi@chromium.org
BUG=440500

Committed: https://crrev.com/ef12824d24aba9469533cb6256eccded3297e94d
Cr-Commit-Position: refs/heads/master@{#362345}
==========

[commit-bot: I haz the power, 2015-12-01 04:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/ef12824d24aba9469533cb6256eccded3297e94d
Cr-Commit-Position: refs/heads/master@{#362345}