net/quic/congestion_control/time_loss_algorithm_test.cc - Issue 1481403005: Fix size_t truncations in net for 64-bit VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/time_loss_algorithm_test.cc

Issue 1481403005: Fix size_t truncations in net for 64-bit VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/congestion_control/time_loss_algorithm_test.cc

diff --git a/net/quic/congestion_control/time_loss_algorithm_test.cc b/net/quic/congestion_control/time_loss_algorithm_test.cc

index 564c43e10d684a7f9517a8002ba080d92bde1bde..b7187356b3118905eb830824e6dcd5b7da8df58d 100644

--- a/net/quic/congestion_control/time_loss_algorithm_test.cc

+++ b/net/quic/congestion_control/time_loss_algorithm_test.cc

@@ -68,7 +68,7 @@ TEST_F(TimeLossAlgorithmTest, NoLossFor500Nacks) {

SendDataPacket(i);

}

unacked_packets_.RemoveFromInFlight(2);

- for (size_t i = 1; i < 500; ++i) {

+ for (uint16 i = 1; i < 500; ++i) {

unacked_packets_.NackPacket(1, i);

VerifyLosses(2, nullptr, 0);

}