[runtime] [proxy] Adding [[SetPrototypeOf]] trap.

[runtime] [proxy] Adding [[SetPrototypeOf]] trap.

LOG=N
BUG=v8:1543
Committed: https://crrev.com/d9e0a5a9adc3e6893c6be0b5494b30e45fda4031
Cr-Commit-Position: refs/heads/master@{#32471}

[Camillo Bruni, 2015-11-30 15:34:33]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 15:34:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481383003/1

[Camillo Bruni, 2015-11-30 15:45:24]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org, neis@chromium.org

[Camillo Bruni, 2015-11-30 15:45:25]

WIP (~96.2%) awaiting land of https://codereview.chromium.org/1481103002 for
rebasing

[commit-bot: I haz the power, 2015-11-30 15:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 15:54:04]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2015-11-30 16:29:18]

Looking good, a few comments.

https://codereview.chromium.org/1481383003/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/1481383003/diff/1/src/messages.h#newcode197
src/messages.h:197: "Proxy handler returned false when setting protoype '%'")   
              \
nit: s/protoype/prototype/

https://codereview.chromium.org/1481383003/diff/1/src/messages.h#newcode198
src/messages.h:198: T(ProxySetPrototypeVioloatesInvariant,                      
                \
nit: s/Violoates/Violates/

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc#newcode14830
src/objects.cc:14830: Object::ShouldThrow should_throw) {
I don't think you need "Object::" here (but you can keep it if you like it).

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc#newcode14840
src/objects.cc:14840: if (!raw_handler->IsJSReceiver()) {
if (proxy->IsRevoked())

https://codereview.chromium.org/1481383003/diff/1/test/mjsunit/harmony/proxie...
File test/mjsunit/harmony/proxies-set-prototype-of.js (right):

https://codereview.chromium.org/1481383003/diff/1/test/mjsunit/harmony/proxie...
test/mjsunit/harmony/proxies-set-prototype-of.js:14: assertThrows(function() {
Object.setPrototypeOf(proxy, undefined) });
Please add the type of error that's expected to be thrown (again for everything
other assertThrows() call below).

[Camillo Bruni, 2015-12-01 13:26:40]

thanks for the feedback,
merged with master and updated.

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc#newcode14830
src/objects.cc:14830: Object::ShouldThrow should_throw) {
On 2015/11/30 at 16:29:18, Jakob wrote:
> I don't think you need "Object::" here (but you can keep it if you like it).

cleaner without.

https://codereview.chromium.org/1481383003/diff/1/src/objects.cc#newcode14840
src/objects.cc:14840: if (!raw_handler->IsJSReceiver()) {
On 2015/11/30 at 16:29:18, Jakob wrote:
> if (proxy->IsRevoked())

right :D

[Camillo Bruni, 2015-12-01 13:33:12]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 13:33:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481383003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481383003/50001

[Jakob Kummerow, 2015-12-01 14:00:21]

lgtm

[commit-bot: I haz the power, 2015-12-01 14:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 14:18:36]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-12-01 14:40:28]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-01 14:40:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481383003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481383003/50001

[commit-bot: I haz the power, 2015-12-01 15:59:40]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-12-01 15:59:48]

Description was changed from

==========
[runtime] [proxy] Adding [[SetPrototypeOf]] trap.

LOG=N
BUG=v8:1543
==========

to

==========
[runtime] [proxy] Adding [[SetPrototypeOf]] trap.

LOG=N
BUG=v8:1543

Committed: https://crrev.com/d9e0a5a9adc3e6893c6be0b5494b30e45fda4031
Cr-Commit-Position: refs/heads/master@{#32471}
==========

[commit-bot: I haz the power, 2015-12-01 15:59:49]

Patchset 4 (id:??) landed as
https://crrev.com/d9e0a5a9adc3e6893c6be0b5494b30e45fda4031
Cr-Commit-Position: refs/heads/master@{#32471}