[proxies] Implement [[Set]].

[proxies] Implement [[Set]].

R=rossberg
BUG=v8:1543
LOG=N

Committed: https://crrev.com/031751d5c421ac21288eb52a2d57f9816edfa910
Cr-Commit-Position: refs/heads/master@{#32457}

[neis, 2015-11-27 15:34:39]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 15:34:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481103002/1

[neis, 2015-11-27 15:35:50]

Description was changed from

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=
==========

to

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=
==========

[commit-bot: I haz the power, 2015-11-27 16:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 16:12:54]

Dry run: This issue passed the CQ dry run.

[neis, 2015-11-30 08:00:40]

neis@chromium.org changed reviewers:
+ verwaest@chromium.org

[Camillo Bruni, 2015-11-30 10:57:58]

cbruni@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2015-11-30 10:57:59]

https://codereview.chromium.org/1481103002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1481103002/diff/1/src/objects.cc#newcode4589
src/objects.cc:4589: !target_desc.configurable() &&
!target_desc.set()->IsUndefined());
Spec says: "If targetDesc.[[Set]] is undefined" :)

[neis, 2015-11-30 13:27:55]

On 2015/11/30 10:57:59, cbruni wrote:
> https://codereview.chromium.org/1481103002/diff/1/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/1481103002/diff/1/src/objects.cc#newcode4589
> src/objects.cc:4589: !target_desc.configurable() &&
> !target_desc.set()->IsUndefined());
> Spec says: "If targetDesc.[[Set]] is undefined" :)

Thanks!  That tells me I should add more tests.

[neis, 2015-12-01 09:55:56]

On 2015/11/30 13:27:55, neis wrote:
> On 2015/11/30 10:57:59, cbruni wrote:
> > https://codereview.chromium.org/1481103002/diff/1/src/objects.cc
> > File src/objects.cc (right):
> > 
> > https://codereview.chromium.org/1481103002/diff/1/src/objects.cc#newcode4589
> > src/objects.cc:4589: !target_desc.configurable() &&
> > !target_desc.set()->IsUndefined());
> > Spec says: "If targetDesc.[[Set]] is undefined" :)
> 
> Thanks!  That tells me I should add more tests.

I removed the spurious negation and added more tests.

[Camillo Bruni, 2015-12-01 10:15:45]

Description was changed from

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=
==========

to

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=v8:1543
LOG=N
==========

[Toon Verwaest, 2015-12-01 11:30:08]

lgtm.
I don't like the generic ProxyTrapViolatesInvariant message that much; it would
be nicer to have specific messages about what is violated exactly. I'm ok with
it as is for now though...

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc#newcode3909
src/objects.cc:3909: if (!owned)
{} if multiline

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc#newcode3911
src/objects.cc:3911: if (PropertyDescriptor::IsAccessorDescriptor(&desc) ||
!desc.writable())
same here

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc#newcode4549
src/objects.cc:4549: *factory->NewTypeError(MessageTemplate::kProxyRevoked,
trap_name));
Funny how right after a potential "DONT_THROW" it throws :)
(It's spec-compliant, I know...)

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc#newcode6450
src/objects.cc:6450: ShouldThrow should_throw) {
Perhaps we should add it->AssertOwnLookup() which internally DCHECK_EQ(0, 
configuration & kPrototypeChain) ?
I've had an issue previously where a non-OWN/HIDDEN lookup iterator was passed
into a method like this which just assumed own lookup.

https://codereview.chromium.org/1481103002/diff/40001/src/objects.cc#newcode6454
src/objects.cc:6454: if (receiver->IsJSObject())
{}

[neis, 2015-12-01 12:06:02]

The CQ bit was checked by neis@chromium.org

[neis, 2015-12-01 12:06:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1481103002/#ps80001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-12-01 12:06:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481103002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481103002/80001

[commit-bot: I haz the power, 2015-12-01 12:27:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-01 12:27:17]

Description was changed from

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=v8:1543
LOG=N
==========

to

==========
[proxies] Implement [[Set]].

R=rossberg
BUG=v8:1543
LOG=N

Committed: https://crrev.com/031751d5c421ac21288eb52a2d57f9816edfa910
Cr-Commit-Position: refs/heads/master@{#32457}
==========

[commit-bot: I haz the power, 2015-12-01 12:27:18]

Patchset 5 (id:??) landed as
https://crrev.com/031751d5c421ac21288eb52a2d57f9816edfa910
Cr-Commit-Position: refs/heads/master@{#32457}