CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here: https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink (cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777
UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}

Committed: https://crrev.com/5731b09ecd33ad6324052a44ad6871e24ea9fdbc
Cr-Commit-Position: refs/heads/master@{#363143}

[loyso (OOO), 2015-11-30 04:04:36]

loyso@chromium.org changed reviewers:
+ sky@chromium.org

[loyso (OOO), 2015-11-30 04:31:41]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

HtmlViewer doesn't add animations to cc::Layers for now.
Make sure that HtmlViewer always uses the new animation system
(cc::AnimationHost).

In practice this means that cc::Layers in HtmlViewer compositor don't have
LayerAnimationController.

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

In practice this means that cc::Layers in HtmlViewer compositor don't have
LayerAnimationController.

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

[loyso (OOO), 2015-11-30 04:34:52]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

In practice this means that cc::Layers in HtmlViewer compositor don't have
LayerAnimationController.

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

[sky, 2015-11-30 17:45:30]

https://codereview.chromium.org/1481343002/diff/1/components/html_viewer/html...
File components/html_viewer/html_widget.cc (right):

https://codereview.chromium.org/1481343002/diff/1/components/html_viewer/html...
components/html_viewer/html_widget.cc:97: // Use new animation system
(cc::AnimationHost).
This state looks like it's global state, and not per widget. Can it move to
GlobalState? Or BlinkPlatformImpl if that is appropriate.

[loyso (OOO), 2015-12-02 03:58:27]

https://codereview.chromium.org/1481343002/diff/1/components/html_viewer/html...
File components/html_viewer/html_widget.cc (right):

https://codereview.chromium.org/1481343002/diff/1/components/html_viewer/html...
components/html_viewer/html_widget.cc:97: // Use new animation system
(cc::AnimationHost).
On 2015/11/30 17:45:29, sky wrote:
> This state looks like it's global state, and not per widget. Can it move to
> GlobalState? Or BlinkPlatformImpl if that is appropriate.

Done.

[loyso (OOO), 2015-12-03 03:27:23]

sky@, PTAL?

[sky, 2015-12-03 04:42:34]

LGTM

[loyso (OOO), 2015-12-03 04:45:05]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2015-12-03 04:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481343002/20001

[commit-bot: I haz the power, 2015-12-03 05:00:26]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

[commit-bot: I haz the power, 2015-12-03 05:00:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 05:01:08]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

[commit-bot: I haz the power, 2015-12-03 05:01:09]

Patchset 2 (id:??) landed as
https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}

[battre, 2015-12-03 10:59:41]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1500513003/ by battre@chromium.org.

The reason for reverting is: Revert because WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward started failing..

[loyso (OOO), 2015-12-03 23:54:13]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

[loyso (OOO), 2015-12-04 04:44:04]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

[loyso (OOO), 2015-12-04 04:44:43]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

[loyso (OOO), 2015-12-04 04:53:43]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2015-12-04 04:53:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1481343002/#ps60001
(title: "Rebase to pick up a fix.")

[commit-bot: I haz the power, 2015-12-04 04:54:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481343002/60001

[commit-bot: I haz the power, 2015-12-04 05:41:47]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

[commit-bot: I haz the power, 2015-12-04 05:41:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-04 05:42:47]

Description was changed from

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}
==========

to

==========
CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines

In general, we want to enable external animation system for blink here:
https://codereview.chromium.org/1308053006/

Make sure that HtmlViewer always uses the new animation system for CC and Blink
(cc::AnimationHost).

Eventually, we will delete LayerSettings everywhere.

BUG=394777

UPDATE:
WebViewTest.CanGoBackAndForward and
WebViewTest.NavigationClearsForward were failing
because this fix was not landed:
https://codereview.chromium.org/1459023002/

Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
Cr-Commit-Position: refs/heads/master@{#362911}

Committed: https://crrev.com/5731b09ecd33ad6324052a44ad6871e24ea9fdbc
Cr-Commit-Position: refs/heads/master@{#363143}
==========

[commit-bot: I haz the power, 2015-12-04 05:42:48]

Patchset 4 (id:??) landed as
https://crrev.com/5731b09ecd33ad6324052a44ad6871e24ea9fdbc
Cr-Commit-Position: refs/heads/master@{#363143}