Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/constants_x64.h

Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/code_patcher_arm.cc ('K') | « runtime/vm/constants_mips.h ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_x64.h
===================================================================
--- runtime/vm/constants_x64.h (revision 22345)
+++ runtime/vm/constants_x64.h (working copy)
@@ -99,9 +99,11 @@
const Register kStackTraceObjectReg = RDX;
+// TODO(regis): Move these constants to stack_frame_x64.h.
// Dart stack frame layout.
-static const int kLastParamSlotIndex = 2;
-static const int kFirstLocalSlotIndex = -2;
+static const int kLastParamSlotIndex = 2; // From fp.
+static const int kFirstLocalSlotIndex = -2; // From fp.
+static const int kPcSlotIndexFromSp = -1;
srdjan 2013/05/03 17:16:18 Add an ASCII drawing explaining the constants.
regis 2013/05/03 18:34:12 Done.
enum ScaleFactor {
« runtime/vm/code_patcher_arm.cc ('K') | « runtime/vm/constants_mips.h ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698