Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: runtime/vm/code_patcher_arm.cc

Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_patcher_arm.cc
===================================================================
--- runtime/vm/code_patcher_arm.cc (revision 22345)
+++ runtime/vm/code_patcher_arm.cc (working copy)
@@ -39,7 +39,9 @@
void CodePatcher::InsertCallAt(uword start, uword target) {
- UNIMPLEMENTED();
+ // The inserted call should not overlap the lazy deopt jump code.
+ ASSERT(start + CallPattern::kFixedLengthInBytes <= target);
srdjan 2013/05/03 17:16:18 Currently there is always a patch jump before the
regis 2013/05/03 18:34:12 Agreed. It will not catch all issues.
+ CallPattern::InsertAt(start, target);
}

Powered by Google App Engine
This is Rietveld 408576698