runtime/vm/code_patcher_x64.cc - Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_patcher_x64.cc

Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_patcher_x64.cc

===================================================================

--- runtime/vm/code_patcher_x64.cc (revision 22345)

+++ runtime/vm/code_patcher_x64.cc (working copy)

@@ -173,6 +173,8 @@

void CodePatcher::InsertCallAt(uword start, uword target) {

+ // The inserted call should not overlap the lazy deopt jump code.

+ ASSERT(start + ShortCallPattern::InstructionLength() <= target);

*reinterpret_cast<uint8_t*>(start) = 0xE8;

ShortCallPattern call(start);

call.SetTargetAddress(target);

« runtime/vm/code_patcher_arm.cc ('K') | « runtime/vm/code_patcher_ia32.cc ('k') | runtime/vm/constants_arm.h » ('j') | runtime/vm/constants_x64.h » ('J')