Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1481163002: Drop [LegacyInterfaceTypeChecking] for SpeechSynthesis.prototype.speak (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for SpeechSynthesis.prototype.speak This changes only the exception message. There are no internal calls to SpeechSynthesis::speak, so the ASSERT(utterance) will hold. BUG=561338 Committed: https://crrev.com/811bba14d61d93ceec0f19bdbef758714251974f Cr-Commit-Position: refs/heads/master@{#364303}

Patch Set 1 #

Patch Set 2 : update tests #

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481163002/20001
5 years ago (2015-11-30 09:51:52 UTC) #3
philipj_slow
PTAL
5 years ago (2015-11-30 10:39:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 11:02:38 UTC) #8
philipj_slow
Friendly ping :)
5 years ago (2015-12-02 14:07:28 UTC) #9
philipj_slow
Friendly ping 2
5 years ago (2015-12-09 21:56:28 UTC) #10
dmazzoni
lgtm
5 years ago (2015-12-10 05:19:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481163002/20001
5 years ago (2015-12-10 05:21:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 06:51:45 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-10 06:52:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/811bba14d61d93ceec0f19bdbef758714251974f
Cr-Commit-Position: refs/heads/master@{#364303}

Powered by Google App Engine
This is Rietveld 408576698