third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp - Issue 1481163002: Drop [LegacyInterfaceTypeChecking] for SpeechSynthesis.prototype.speak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

Issue 1481163002: Drop [LegacyInterfaceTypeChecking] for SpeechSynthesis.prototype.speak (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesis.h ('k') | third_party/WebKit/Source/modules/speech/SpeechSynthesis.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

index 454956d2a1131e19744f9f2f8630f250645e6e0d..8fdff01ad926612984497decbb94271e45098201 100644

--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

@@ -26,7 +26,6 @@

#include "config.h"

#include "modules/speech/SpeechSynthesis.h"

-#include "bindings/core/v8/ExceptionState.h"

#include "core/dom/ExecutionContext.h"

#include "modules/speech/SpeechSynthesisEvent.h"

#include "platform/speech/PlatformSpeechSynthesisVoice.h"

@@ -106,12 +105,9 @@ void SpeechSynthesis::startSpeakingImmediately()

m_platformSpeechSynthesizer->speak(utterance->platformUtterance());

}

-void SpeechSynthesis::speak(SpeechSynthesisUtterance* utterance, ExceptionState& exceptionState)

+void SpeechSynthesis::speak(SpeechSynthesisUtterance* utterance)

{

- if (!utterance) {

- exceptionState.throwTypeError("Invalid utterance argument");

- return;

- }

+ ASSERT(utterance);

m_utteranceQueue.append(utterance);