Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1481123002: Use SVGLength's wrapped CSSPrimitiveValue for pres.attr. style (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SVGLength's wrapped CSSPrimitiveValue for pres.attr. style Since SVGLength now wraps a CSSPrimitiveValue, there's no need to create a (potentially new) CSSPrimitiveValue when collecting presentation attribute style for SVG elements. Could save an allocation in some cases. Gets rid of the addSVGLengthPropertyToPresentationAttributeStyle helper on SVGElement. Committed: https://crrev.com/8cceecb12a9fe3e08d9c2ff87dc64e00c76435ac Cr-Commit-Position: refs/heads/master@{#362680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
fs
5 years ago (2015-11-30 10:18:51 UTC) #2
pdr.
lgtm LGTM, nooice
5 years ago (2015-12-01 22:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481123002/1
5 years ago (2015-12-01 23:00:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/129659)
5 years ago (2015-12-02 00:26:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481123002/1
5 years ago (2015-12-02 00:33:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148472)
5 years ago (2015-12-02 02:24:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481123002/1
5 years ago (2015-12-02 10:03:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 11:09:06 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-02 11:10:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cceecb12a9fe3e08d9c2ff87dc64e00c76435ac
Cr-Commit-Position: refs/heads/master@{#362680}

Powered by Google App Engine
This is Rietveld 408576698