Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1481123002: Use SVGLength's wrapped CSSPrimitiveValue for pres.attr. style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 return cssPropertyIdForSVGAttributeName(name) > 0; 700 return cssPropertyIdForSVGAttributeName(name) > 0;
701 } 701 }
702 702
703 void SVGElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style) 703 void SVGElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)
704 { 704 {
705 CSSPropertyID propertyID = cssPropertyIdForSVGAttributeName(name); 705 CSSPropertyID propertyID = cssPropertyIdForSVGAttributeName(name);
706 if (propertyID > 0) 706 if (propertyID > 0)
707 addPropertyToPresentationAttributeStyle(style, propertyID, value); 707 addPropertyToPresentationAttributeStyle(style, propertyID, value);
708 } 708 }
709 709
710 void SVGElement::addSVGLengthPropertyToPresentationAttributeStyle(MutableStylePr opertySet* style, CSSPropertyID property, SVGLength& length)
711 {
712 addPropertyToPresentationAttributeStyle(style, property,
713 length.valueInSpecifiedUnits(),
714 length.cssUnitTypeQuirk());
715 }
716
717 bool SVGElement::haveLoadedRequiredResources() 710 bool SVGElement::haveLoadedRequiredResources()
718 { 711 {
719 for (SVGElement* child = Traversal<SVGElement>::firstChild(*this); child; ch ild = Traversal<SVGElement>::nextSibling(*child)) { 712 for (SVGElement* child = Traversal<SVGElement>::firstChild(*this); child; ch ild = Traversal<SVGElement>::nextSibling(*child)) {
720 if (!child->haveLoadedRequiredResources()) 713 if (!child->haveLoadedRequiredResources())
721 return false; 714 return false;
722 } 715 }
723 return true; 716 return true;
724 } 717 }
725 718
726 static inline void collectInstancesForSVGElement(SVGElement* element, WillBeHeap HashSet<RawPtrWillBeWeakMember<SVGElement>>& instances) 719 static inline void collectInstancesForSVGElement(SVGElement* element, WillBeHeap HashSet<RawPtrWillBeWeakMember<SVGElement>>& instances)
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
1159 Element::trace(visitor); 1152 Element::trace(visitor);
1160 } 1153 }
1161 1154
1162 const AtomicString& SVGElement::eventParameterName() 1155 const AtomicString& SVGElement::eventParameterName()
1163 { 1156 {
1164 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::Con structFromLiteral)); 1157 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::Con structFromLiteral));
1165 return evtString; 1158 return evtString;
1166 } 1159 }
1167 1160
1168 } // namespace blink 1161 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698