Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: src/objects.h

Issue 1481103002: [proxies] Implement [[Set]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 23d8038be021ad6b4419a498a34fc29db9b85ab7..5ff015cbc409e956ce7e33e2cb6d9d441bce5221 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1832,9 +1832,9 @@ class JSReceiver: public HeapObject {
Handle<Object> key, PropertyDescriptor* desc,
ShouldThrow should_throw);
- // "virtual" dispatcher to the correct [[CreateDataProperty]] implementation.
- MUST_USE_RESULT static Maybe<bool> CreateDataProperty(LookupIterator* it,
- Handle<Object> value);
+ // ES6 7.3.4 (when passed DONT_THROW)
+ MUST_USE_RESULT static Maybe<bool> CreateDataProperty(
+ LookupIterator* it, Handle<Object> value, ShouldThrow should_throw);
// ES6 9.1.6.1
static bool OrdinaryDefineOwnProperty(Isolate* isolate,
@@ -9539,22 +9539,14 @@ class JSProxy: public JSReceiver {
Handle<Object> receiver,
Handle<Name> name);
- // If the handler defines an accessor property with a setter, invoke it.
- // If it defines an accessor property without a setter, or a data property
- // that is read-only, fail. In all these cases set '*done' to true.
- // Otherwise set it to false, in which case the return value is not
- // meaningful.
- MUST_USE_RESULT
- static Maybe<bool> SetPropertyViaPrototypesWithHandler(
- Handle<JSProxy> proxy, Handle<Object> receiver, Handle<Name> name,
- Handle<Object> value, ShouldThrow should_throw, bool* done);
-
MUST_USE_RESULT static Maybe<PropertyAttributes> GetPropertyAttributes(
LookupIterator* it);
- MUST_USE_RESULT static Maybe<bool> SetPropertyWithHandler(
- Handle<JSProxy> proxy, Handle<Object> receiver, Handle<Name> name,
- Handle<Object> value, ShouldThrow should_throw);
+ MUST_USE_RESULT static Maybe<bool> SetProperty(Handle<JSProxy> proxy,
+ Handle<Name> name,
+ Handle<Object> value,
+ Handle<Object> receiver,
+ LanguageMode language_mode);
// Dispatched behavior.
DECLARE_PRINTER(JSProxy)
« no previous file with comments | « src/messages.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698