content/public/common/password_form.h - Issue 14811010: Add metadata to content::PasswordForm to keep track of the password usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/password_form.h

Issue 14811010: Add metadata to content::PasswordForm to keep track of the password usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_form_manager.cc ('K') | « content/public/common/common_param_traits_macros.h ('k') | content/public/common/password_form.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/password_form.h

diff --git a/content/public/common/password_form.h b/content/public/common/password_form.h

index 21b2e56769858a01a7bd54724628b14a06fbb786..0f0ea4ce1d0543acdffe36354ab7289ffa58f4ad 100644

--- a/content/public/common/password_form.h

+++ b/content/public/common/password_form.h

@@ -157,6 +157,12 @@ struct CONTENT_EXPORT PasswordForm {

// The form type. Not used yet. Please see http://crbug.com/152422

Type type;

+ // The number of times that this username/password has been used to

+ // authenticate the user.

+ //

+ // When parsing an HTML form, this is not used.

+ int times_used;

Ilya Sherman 2013/05/14 07:25:34 nit: size_t?

Garrett Casto 2013/05/14 20:17:58 I'd prefer not. There is some ambiguity in the chr

PasswordForm();

~PasswordForm();

};